Skip to content

Commit

Permalink
fixup! notes
Browse files Browse the repository at this point in the history
  • Loading branch information
erights committed Nov 18, 2024
1 parent f5a7c70 commit 851ac3b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,11 @@ export const prepareMockIssuerKit = zone => {
const paymentRecoveryFacet = paymentRecoveryFacets.get(payment);
paymentRecoveryFacet.unencumber(amount);
paymentRecoveryFacet.deletePayment(payment);
// TODO must all burn the same orch denom assets
// so the fullBalance goes down and the unencumbered balance
// eventually stays the same.
// Without this, the unencumbered balance will go up, which is
// completely broken.
}
},
},
Expand Down
5 changes: 5 additions & 0 deletions packages/orchestration/src/mock-orch-ertp/notes.txt
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ ertp reclaim(a), like a successful self.deposit(a)
eb -= a
fb unchanged

mintTo(d, a), like succeed case of transfer
dub += a
deb unchanged
dfb += a

if orch account can be independently spent from
ub can go negative, if fb < eb
payments can fail to be deposited

0 comments on commit 851ac3b

Please sign in to comment.