consolidate lint job (#8061)

_no issue_

## Description

#8058 made linting with types fast enough to enable again. It's even fast enough now that the splitting doesn't save any time.

This gets rid of the `lint-with-types.sh` script that managed the splitting. The CI job now just runs `yarn lint`. Doing that required that each package's `yarn lint` command has types enabled, so it does that too.

An upshot is that now running `yarn lint` locally will check no-floating-promises, even though the IDE still doesn't.

### Security Considerations

n/a

### Scaling Considerations

n/a

### Documentation Considerations

reduces need to document

### Testing Considerations

CI.

~Once it passes, someone will have to update branch protections to remove the split primary/rest requirements.~ When this PR started there wasn't a point to two jobs, but now the second job covers a3p-integration so it's worth keeping

.github/workflows/test-all-packages.yml

@@ -82,7 +82,7 @@ jobs:
   # We split the package tests into two jobs because type linting
   # is inefficient and slow https://github.com/typescript-eslint/typescript-eslint/issues/2094
   lint-primary:
-    timeout-minutes: 15
+    timeout-minutes: 20
     needs: build
     runs-on: ubuntu-latest
     steps:
@@ -91,22 +91,19 @@ jobs:
         with:
           node-version: '18.x'
 
-      # first job also does repo-level linting
       - name: lint repo format
         run: yarn lint:format
-      # eslint
-      - name: yarn lint primary
-        run: ./scripts/lint-with-types.sh primary
+      # eslint and tsc
+      - run: yarn lint:packages
       # build the API docs to verify it works
       - name: build API docs
         run: yarn docs
       # build the API docs in markdown for agoric/documentation repo to verify it works
       - name: build API docs in markdown
         run: yarn docs:markdown-for-agoric-documentation-repo
 
+  # A second job for what's not covered in primary
   lint-rest:
-    timeout-minutes: 15
-    needs: build
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -117,8 +114,6 @@ jobs:
       # Check some of a3p-integration in this job that runs on PRs instead of
       # waiting for the slow integration test that by default only runs in the
       # master merge check
-      - name: yarn lint rest of packages/*
-        run: ./scripts/lint-with-types.sh rest
       - name: Lint a3p-integration
         run: yarn install && yarn lint && yarn doctor
         working-directory: a3p-integration