Skip to content

Commit

Permalink
lint: restore ts-ignore
Browse files Browse the repository at this point in the history
This reverts commit 7f4d952.

Co-authored-by: Turadg Aleahmad <[email protected]>
  • Loading branch information
erights and turadg committed Jul 8, 2024
1 parent 94ec93c commit 3c531f5
Showing 1 changed file with 16 additions and 2 deletions.
18 changes: 16 additions & 2 deletions packages/async-flow/src/replay-membrane.js
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,14 @@ export const makeReplayMembrane = ({
try {
optVerb
? heapVowE.sendOnly(hostTarget)[optVerb](...hostArgs)
: // @ts-expect-error XXX heapVowE
: // eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore once we changed this from E to heapVowE,
// typescript started complaining that heapVowE(hostTarget)
// is not callable. I'm not sure if this is a just a typing bug
// in heapVowE or also reflects a runtime deficiency. But this
// case it not used yet anyway. We disable it
// with at-ts-ignore rather than at-ts-expect-error because
// the dependency-graph tests complains that the latter is unused.
heapVowE.sendOnly(hostTarget)(...hostArgs);
} catch (hostProblem) {
throw Panic`internal: eventual sendOnly synchrously failed ${hostProblem}`;
Expand Down Expand Up @@ -313,7 +320,14 @@ export const makeReplayMembrane = ({
try {
const hostPromise = optVerb
? heapVowE(hostTarget)[optVerb](...hostArgs)
: // @ts-expect-error XXX heapVowE
: // eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore once we changed this from E to heapVowE,
// typescript started complaining that heapVowE(hostTarget)
// is not callable. I'm not sure if this is a just a typing bug
// in heapVowE or also reflects a runtime deficiency. But this
// case it not used yet anyway. We disable it
// with at-ts-ignore rather than at-ts-expect-error because
// the dependency-graph tests complains that the latter is unused.
heapVowE(hostTarget)(...hostArgs);
resolver.resolve(hostPromise); // TODO does this always work?
} catch (hostProblem) {
Expand Down

0 comments on commit 3c531f5

Please sign in to comment.