-
Notifications
You must be signed in to change notification settings - Fork 214
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(sync-tools): add method to wait until offer has exited (#10462)
closes: https://github.com/Agoric/BytePitchPartnerEng/issues/38 ## Description This PR aims to extend the available `sync-tools` by providing a method that allows the developer to verify that an offer was successfully exited via the execution of a `tryExitOffer` call. The method `waitUntilOfferExited` will poll the user's wallet `liveOffers` and check if the respective `offerId` is no longer present. ### Security Considerations No new assumptions or dependencies were introduced. ### Scaling Considerations No requirements for increased resources. ### Documentation Considerations This additional tool does not impact backward compatibility. Although it may be useful to inform the developer that intends to use this method to prevent a false positive, it should first verify that the offerID is indeed present in the user's wallet liveOffers before calling `tryExitOffer`. ### Testing Considerations I have confirmed that this method works as expected when used locally at the a3p-integration acceptance tests. The test used is not included in the PR, since it would be out of scope. ### Upgrade Considerations No impact is expected for live production systems.
- Loading branch information
Showing
4 changed files
with
58 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters