Skip to content

Commit

Permalink
chore: minor nitpicking (#10525)
Browse files Browse the repository at this point in the history
_Incidental_

## Description

Independent changes that are best reviewed commit-by-commit:
-  chore(fast-usdc): publish for `@agoric/builders` to use, since it is published to NPM and has a hard dependency on `@agoric/fast-usdc`
- test(e2e-tools): provide `proposal_id` and fix the "propsal [sic]" typo
- ci(lint-rest): move `lint-primary` doc generation to rebalance (since it was the longest-running non-integration ci job)
- ci(dump-ci-stats): bump action versions to use the same ones as other workflows, avoiding deprecation warnings

### Security Considerations

n/a

### Scaling Considerations

Slightly faster CI times.

### Documentation Considerations

n/a

### Testing Considerations

n/a

### Upgrade Considerations

n/a
  • Loading branch information
mergify[bot] authored Nov 19, 2024
2 parents 9c61393 + 266117a commit 02967de
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 11 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/dump-ci-stats.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout Code
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Set up Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: '18'

Expand Down
13 changes: 7 additions & 6 deletions .github/workflows/test-all-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,6 @@ jobs:
run: yarn lint:format
# eslint and tsc
- run: yarn lint:packages
# build the API docs to verify it works
- name: build API docs
run: yarn docs
# build the API docs in markdown for agoric/documentation repo to verify it works
- name: build API docs in markdown
run: yarn docs:markdown-for-agoric-documentation-repo

# A second job for what's not covered in primary
lint-rest:
Expand All @@ -121,6 +115,13 @@ jobs:
run: yarn run build:submissions
working-directory: a3p-integration

# Attempt the doc generation to catch build errors before
# landing on master
- name: build API docs
run: yarn docs
- name: build API docs in markdown
run: yarn docs:markdown-for-agoric-documentation-repo

##################
# Fast-running tests run as a group:
test-quick:
Expand Down
7 changes: 5 additions & 2 deletions multichain-testing/tools/e2e-tools.js
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ const voteLatestProposalAndWait = async ({
}

// @ts-expect-error cast
return info;
return { ...info, proposal_id: lastProposalId };
};

/**
Expand Down Expand Up @@ -399,7 +399,10 @@ const runCoreEval = async (
log(detail.proposal_id, detail.voting_end_time, detail.status);

// TODO: how long is long enough? poll?
await blockTool.waitForBlock(5, { step: 'run', propsal: detail.proposal_id });
await blockTool.waitForBlock(5, {
step: 'run',
proposal: detail.proposal_id,
});

assert(detail.status, 'PROPOSAL_STATUS_PASSED');
return detail;
Expand Down
1 change: 1 addition & 0 deletions packages/fast-usdc/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Change Log
4 changes: 3 additions & 1 deletion packages/fast-usdc/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"name": "@agoric/fast-usdc",
"private": true,
"version": "0.1.0",
"description": "CLI and library for Fast USDC product",
"type": "module",
Expand Down Expand Up @@ -74,5 +73,8 @@
"@endo/init/debug.js"
],
"timeout": "20m"
},
"publishConfig": {
"access": "public"
}
}

0 comments on commit 02967de

Please sign in to comment.