fixup test runner #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
approved these changes
Nov 3, 2023
proposals/43:upgrade-11/legacy.sh
Outdated
| @@ -4,7 +4,6 @@ | |||
| source /usr/src/upgrade-test-scripts/env_setup.sh | |||
|
|
|||
| # Enable debugging | |||
| set -x | |||
|
|
|||
There was a problem hiding this comment.
the "Enable debugging" comment stays? on purpose?
not a big deal...
There was a problem hiding this comment.
oops, will remove. (CI's not passing anyway)
| @@ -29,7 +29,7 @@ ENV UPGRADE_TO=${to} THIS_NAME=${agZeroUpgrade} | |||
| # put env functions into shell environment | |||
| RUN echo '. /usr/src/upgrade-test-scripts/env_setup.sh' >> ~/.bashrc | |||
|
|
|||
| COPY --chmod=755 ./upgrade-test-scripts /usr/src/upgrade-test-scripts | |||
| COPY --link --chmod=755 ./upgrade-test-scripts /usr/src/upgrade-test-scripts | |||
| fs.writeFileSync('Dockerfile', contents); | ||
| } | ||
|
|
||
| if (require.main === module) { |
There was a problem hiding this comment.
I thought we used ES modules and node doesn't support this idiom in that context.
Does .ts not get compiled to ES modules?
There was a problem hiding this comment.
Node only uses ESM if package.json has "type": "module". But there's no package.json here so it defaults to CJS
iomekam
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one got lost in the commit cleanups:
These I'm slipping in as well: