-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solve disk usage #79
solve disk usage #79
Changes from 1 commit
610ab2a
d9716b9
df72419
c8372b3
4d008fb
161a066
e8fce15
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,13 +64,16 @@ export const buildProposalSubmissions = (proposals: ProposalInfo[]) => { | |
|
||
/** | ||
* Bake images using the docker buildx bake command. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not familiar with |
||
* | ||
* Note this uses `--load` which pushes the completed images to the builder, | ||
* consuming 2-3 GB per image. | ||
* @see {@link https://docs.docker.com/engine/reference/commandline/buildx_build/#load} | ||
* | ||
* @param matrix - The group target | ||
* @param target - The image or group target | ||
* @param [dry] - Whether to skip building and just print the build config. | ||
*/ | ||
export const bakeImages = (matrix: 'test' | 'use', dry = false) => { | ||
// https://docs.docker.com/engine/reference/commandline/buildx_build/#load | ||
const cmd = `docker buildx bake --load ${matrix} ${dry ? '--print' : ''}`; | ||
export const bakeTarget = (target: string, dry = false) => { | ||
const cmd = `docker buildx bake --load ${target} ${dry ? '--print' : ''}`; | ||
console.log(cmd); | ||
execSync(cmd, { stdio: 'inherit' }); | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,12 @@ | ||
import { execSync } from 'node:child_process'; | ||
import { ProposalInfo, imageNameForProposal } from './proposals.js'; | ||
|
||
export const runTestImages = (proposals: ProposalInfo[]) => { | ||
for (const proposal of proposals) { | ||
console.log(`Running test image for proposal ${proposal.proposalName}`); | ||
const { name } = imageNameForProposal(proposal, 'test'); | ||
// 'rm' to remove the container when it exits | ||
const cmd = `docker run --rm ${name}`; | ||
execSync(cmd, { stdio: 'inherit' }); | ||
} | ||
export const runTestImage = (proposal: ProposalInfo) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the API change from There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the CLI's modules aren't part of the package API. The package doesn't yet define That said, this package doesn't claim backwards compatibility because, following semver, it's not yet 1.0. |
||
console.log(`Running test image for proposal ${proposal.proposalName}`); | ||
const { name } = imageNameForProposal(proposal, 'test'); | ||
// 'rm' to remove the container when it exits | ||
const cmd = `docker run --rm ${name}`; | ||
execSync(cmd, { stdio: 'inherit' }); | ||
}; | ||
|
||
export const debugTestImage = (proposal: ProposalInfo) => { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gather this
docker rmi ...
is the gist of it.