fix default entrypoint #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
approved these changes
Jan 9, 2024
Comment on lines
+246
to
+250
| // If one of the proposals is a passed proposal, make the latest one the default entrypoint | ||
| const lastPassed = lastPassedProposal(allProposals); | ||
| if (lastPassed) { | ||
| blocks.push(stage.DEFAULT(lastPassed)); | ||
| } |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the shuffle to Agoric-SDK and back, #46 lost the
lastPassedProposalfunctionality.That made the
mainimage include more pending proposals, which broke agoric-sdk integration builds. Agoric/agoric-sdk@34fe9a4 is a work-around that I'll revert after this image builds.This fixed doesn't need a release because this new code won't execute outside this repo.