-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement appending #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am somewhat out of my depth here to be able to review this.
One thing that confuses me is whether the "rebuild" command is meant to be used outside of this repo? In which case, what does it "rebuild"?
It currently only makes sense to use in this repo. It rebuilds all proposals starting from agzero. Another option is to eliminate this command and always "append" but appending to agZero is a special case. I figured it was better to separate the use case instead of detecting the tag name. |
I find "build" less confusing than "rebuild" which implies some existing information exists. I'm also thinking that "build" command should also take a base image (not just tag)? |
I'm open to that. It was
You mean the |
I actually meant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little fuzzy on the concept, but it looks like forward progress.
Closes: Agoric/agoric-sdk#8605
This adds an
append
command that executes the proposals on top of an existing image. It takes an optional tag, defaulting to main.I published an rc0 so this could be used in Agoric/agoric-sdk#8635. Then I realized the CLI names could be improved so I added a commit for that. I didn't fixup the previous because rc0 had been cut. I'll cut a release after this PR merges. I also need to set up a auto-publishing on merge.