fix: miscellaneous cleanups #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
force-pushed
the
mfig-split-docker
branch
4 times, most recently
from
82fb01b to
cf9dfcb
Compare
turadg
force-pushed
the
mfig-misc-cleanups
branch
from
b77e52a to
1265d17
Compare
mhofman
approved these changes
Jan 17, 2024
| latest_height=$(ag0 status | jq -r .SyncInfo.latest_block_height) | ||
| height=$(($latest_height + $voting_period_s + 10)) | ||
|
|
||
| latest_height=$(agd status | jq -r .SyncInfo.latest_block_height) |
There was a problem hiding this comment.
nit: the ag0 -> agd rename here should be in the previous commit
There was a problem hiding this comment.
Agree. Though I think it's worth letting slide to land this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to build Docker images with QEMU, I fixed a few issues with sensitivity to races and timeouts. Here they are:
PROPOSAL_STATUS_FAILED, which means the upgrade was scheduled to start before the voting period was oversoftware-upgradeheight to mitigate thePROPOSAL_STATUS_FAILEDproblemsAlso for my sanity when working on the
start_*.shscripts:agdtoag0instart_ag0.shto reduce noise when trying to compare or copy-and-paste code fromstart_to_to.sh.