Push smart wallet #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may eventually be turned into a PR for review, but at this point it's a vehicle for sharing my state so I can get help tracing a problem.
When I run the upgrade, the kernel reports vat-upgrade failure, with no additional details about what went wrong. I have tried many things to get more information, but everything looks fine right up to the point of the call into the kernel and the kernel gives no clues about what's wrong.
I can do an upgrade from the current top-of-tree smartWallet to the refactored version in a variant of
packages/smart-wallet/test/swingsetTests/upgradeWalletFactoryThis upgrade fails whether it's with the existing Zoe/ZCF, an upgraded (and instrumented) Zoe/ZCF, or when it's a null-upgrade of the walletFactory.
The corresponding PR in agoric-sdk is Agoric/agoric-sdk#8560. It has a proposal and can build bundles.