Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Downgrade execa to 8.x to resolve a CI failure #202

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

gibson042
Copy link
Member

@gibson042 gibson042 commented Nov 21, 2024

https://github.com/Agoric/agoric-3-proposals/actions/runs/11943620272/job/33293003574?pr=201#step:10:9712

file:///usr/src/proposals/34:upgrade-10/node_modules/@agoric/synthetic-chain/node_modules/execa/lib/utils/max-listeners.js:1
import {addAbortListener} from 'node:events';
        ^^^^^^^^^^^^^^^^
SyntaxError: The requested module 'node:events' does not provide an export named 'addAbortListener'

I'm trying to use the latest version @agoric/synthetic-chain in the proposals, but running into a Node.js incompatibility. I think we'll probably end up freezing old ones in the long term, but this should make it possible to improve our baseline for now.

@agoric/synthetic-chain library

  • passes CI
  • bump patch version
  • publish

```
file:///usr/src/proposals/34:upgrade-10/node_modules/@agoric/synthetic-chain/node_modules/execa/lib/utils/max-listeners.js:1
import {addAbortListener} from 'node:events';
        ^^^^^^^^^^^^^^^^
SyntaxError: The requested module 'node:events' does not provide an export named 'addAbortListener'
```
@gibson042 gibson042 requested a review from turadg November 21, 2024 00:31
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I don't know what release that change came in. it's not in the release notes.

I don't think we need anything in particular from 9.x

@gibson042 gibson042 merged commit fe9d05a into main Nov 21, 2024
2 checks passed
@gibson042 gibson042 deleted the gibson-2024-11-downgrade-execa branch November 21, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants