feat(synthetic-chain): Propagate environment variable SLOGFILE into containers #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
reviewed
Nov 2, 2024
Comment on lines
8
to
13
| let slogOpts = ''; | ||
| const { SLOGFILE } = process.env; | ||
| if (SLOGFILE) { | ||
| execSync(`touch "$SLOGFILE"`); | ||
| slogOpts = `-e SLOGFILE -v "$SLOGFILE:${realpathSync(SLOGFILE)}"`; | ||
| } |
There was a problem hiding this comment.
Please DRY out producing slogOpts.
Have you considered making it an explicit option instead of an env var? Might help with discovery. Though you're probably the target user so I defer to however you want it to work.
There was a problem hiding this comment.
Please DRY out producing
slogOpts.
Done.
Have you considered making it an explicit option instead of an env var? Might help with discovery. Though you're probably the target user so I defer to however you want it to work.
I considered it, but there's a lot of layers to penetrate and I think I want this to be dynamically configurable. But it can always be added in the future.
gibson042
force-pushed
the
gibson-2024-11-propagate-slogfile
branch
from
bed0caf to
41d8d15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. https://docs.docker.com/reference/cli/docker/container/run/#env