fix submit-proposal gas #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
force-pushed
the
ta/fix-gas
branch
5 times, most recently
from
5975c12 to
83827eb
Compare
|
dropping to draft while I use this to debug #93 |
turadg
force-pushed
the
ta/fix-gas
branch
4 times, most recently
from
b7cc48a to
783d94c
Compare
fortunately [/s] we have other failures now, so I pared this down to the commits to fix gas and am requesting review |
0xpatrickdev
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#120 was failing due to insufficient gas. E.g. the build for prepare-upgrade-14-rc1 had:
It has a fix but this pulls it out since that PR shouldn't merge to main.
This also includes the removal of the pending Zoe proposal because it's tested now in agoric-sdk and #113, which will soon be merged.