Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable CI #1

Merged
merged 4 commits into from
Oct 26, 2023
Merged

enable CI #1

merged 4 commits into from
Oct 26, 2023

Conversation

turadg
Copy link
Member

@turadg turadg commented Oct 25, 2023 •
edited
Loading

refs: Agoric/agoric-sdk#8443

  • remove SDK building feature
  • fix FINAL stage
  • enable CI

@turadg turadg requested review from dckc and iomekam October 25, 2023 21:52
dckc
dckc approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

I expect you'll fixup the fixup, but I don't consider that critical.

iomekam
iomekam approved these changes Oct 26, 2023
View reviewed changes
Copy link

@iomekam iomekam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@turadg turadg merged commit f6e2e9a into main Oct 26, 2023
1 check passed
@turadg turadg deleted the enable-ci branch October 26, 2023 17:29
turadg pushed a commit that referenced this pull request Dec 13, 2023
@anilhelvaci @turadg
feat: include c:crabble-start
2453b36 
Code run in #1

init work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iomekam iomekam iomekam approved these changes

@dckc dckc dckc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turadg @dckc @iomekam