Skip to content

Commit

Permalink
ci(docker): disable arm64 builds for now, due to two blockers
Browse files Browse the repository at this point in the history
- Docker using QEMU on amd64 is way too slow to produce amd64 images.
- Github macos-latest-xlarge M1 runners don't support Docker
  • Loading branch information
michaelfig committed Dec 2, 2023
1 parent bd24baa commit 1962454
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ jobs:
run: |
DEFAULT_PLATFORM=linux/amd64
echo "default=$DEFAULT_PLATFORM" >> $GITHUB_OUTPUT
if ${{ github.event_name == 'pull_request' || github.event_name == 'merge_group' }}; then
# FIXME: Always use just the default platform because QEMU is way too slow to produce images.
if true || ${{ github.event_name == 'pull_request' || github.event_name == 'merge_group' }}; then
platforms='["'"$DEFAULT_PLATFORM"'"]'
else
platforms='["linux/amd64","linux/arm64/v8"]'
Expand All @@ -43,7 +44,9 @@ jobs:
strategy:
matrix:
platform: ${{ fromJSON(needs.platforms.outputs.platforms) }}
runs-on: ${{ contains(matrix.platform, '/arm') && 'macos-latest-xlarge' || 'ubuntu-latest' }}
# FIXME: Can't use this because MacOS doesn't have Docker.
# runs-on: ${{ contains(matrix.platform, '/arm') && 'macos-latest-xlarge' || 'ubuntu-latest' }}
runs-on: ubuntu-latest
steps:
- name: free up disk space
run: |
Expand Down

0 comments on commit 1962454

Please sign in to comment.