Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further scheduled nightly fixes #1934

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Further scheduled nightly fixes #1934

merged 3 commits into from
Feb 13, 2024

Conversation

kessler-frost
Copy link
Member

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

@codecov Codecov
Copy link

codecov bot commented Feb 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f212cb) 84.57% compared to head (71e253c) 84.57%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1934   +/-   ##
========================================
  Coverage    84.57%   84.57%           
========================================
  Files          295      295           
  Lines        14502    14502           
  Branches       195      195           
========================================
  Hits         12265    12265           
  Misses        2103     2103           
  Partials       134      134
Flag Coverage Δ
Dispatcher 92.53% <ø> (ø)
Functional_Tests 51.32% <ø> (ø)
SDK 79.59% <ø> (ø)
UI_Backend 84.53% <ø> (ø)
UI_Frontend 73.35% <ø> (ø)

@kessler-frost kessler-frost marked this pull request as ready for review February 13, 2024 15:22
@kessler-frost kessler-frost requested a review from a team as a code owner February 13, 2024 15:22
AlejandroEsquivel
AlejandroEsquivel previously approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@AlejandroEsquivel AlejandroEsquivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sir 👍🏼

@AlejandroEsquivel AlejandroEsquivel merged commit 170f4d6 into develop Feb 13, 2024
14 checks passed
@AlejandroEsquivel AlejandroEsquivel deleted the more-scheduled-fixes branch February 13, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlejandroEsquivel AlejandroEsquivel AlejandroEsquivel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kessler-frost @AlejandroEsquivel