Parse electron function strings at Electron construction #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waiting until `build_graph()` won't work if the graph is being built in a remote executor without the original source code.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1926 +/- ##
===========================================
+ Coverage 84.57% 85.15% +0.57%
===========================================
Files 295 181 -114
Lines 14502 11288 -3214
Branches 195 0 -195
===========================================
- Hits 12265 9612 -2653
+ Misses 2103 1676 -427
+ Partials 134 0 -134
*This pull request uses carry forward flags. Click here to find out more. |
santoshkumarradha
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
@cjao non blocking, but might be better to have sublattice string test as well along with this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electron function strings were previously parsed during
build_graph(). This doesn't work for electrons in sublattices since they will be built in an executor which typically won't have access to the user's source tree.With this change, all function strings will be parsed client-side when the electron decorator is evaluated.
Tested manually using both Dask and a modified AWSBatch executor image.