Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling qelectron tests and making qelectron opt-in only #1916

Merged
merged 16 commits into from
Jan 26, 2024

Conversation

kessler-frost
Copy link
Member

@kessler-frost kessler-frost commented Jan 22, 2024

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

This PR makes the following changes:

  1. Adds the qelectron tests to the tests github workflow
  2. Makes qelectrons a feature that is opt-in only using pip install covalent[quantum] since it might be blocking some users from upgrading certain versions of dependencies even if they do not require their parent deps in their workflows
  3. Suppresses the harmless sqlalchemy warning that shows up on a fresh covalent start

Resolves #1877
Resolves #1912
Resolves #1907

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (2f46195) 84.53% compared to head (8bc9870) 84.52%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1916      +/-   ##
===========================================
- Coverage    84.53%   84.52%   -0.01%     
===========================================
  Files          295      295              
  Lines        14471    14488      +17     
  Branches       195      195              
===========================================
+ Hits         12233    12246      +13     
- Misses        2104     2108       +4     
  Partials       134      134              
Flag Coverage Δ
Dispatcher 92.53% <100.00%> (+<0.01%) ⬆️
Functional_Tests 51.37% <60.00%> (+0.01%) ⬆️
SDK 79.49% <64.91%> (+0.01%) ⬆️
UI_Backend 84.53% <66.66%> (-0.20%) ⬇️
UI_Frontend 73.35% <ø> (ø)

@kessler-frost kessler-frost marked this pull request as ready for review January 22, 2024 12:03
@kessler-frost kessler-frost requested review from a team as code owners January 22, 2024 12:03
@kessler-frost
Copy link
Member Author

The diff coverage is low because the functions that have been moved to another place didn't already have tests in place.

@kessler-frost
Copy link
Member Author

@Andrew-S-Rosen I think once this PR gets merged, it should unblock you in the sense that we won't have a numpy dependency for covalent. The only thing needed when installing covalent would be to have an environment variable set i.e. COVALENT_DISABLE_QELECTRON=1, and none of the quantum stuff will be installed - thus neither will numpy so you can have whichever numpy version you need.

Simple install command to install the pre-release without numpy dependency once this PR gets merged:

COVALENT_DISABLE_QELECTRON=1 pip install --pre covalent

@Andrew-S-Rosen
Copy link
Contributor

Brilliant, thank you!

@kessler-frost kessler-frost changed the title Enabling qelectron tests and making them opt-outable Enabling qelectron tests and making qelectron opt-in only Jan 24, 2024
@kessler-frost
Copy link
Member Author

To make it further easier, now qelectrons (and its dependencies) are an opt-in only feature (instead of opt-out). In case its installation is required by someone, they will be able to install it using pip install covalent[quantum]. By default none of the quantum dependencies will be installed.

@kessler-frost kessler-frost marked this pull request as draft January 24, 2024 08:21
@kessler-frost kessler-frost marked this pull request as ready for review January 24, 2024 09:53
@kessler-frost kessler-frost requested a review from cjao January 25, 2024 11:01
Copy link
Contributor

@cjao cjao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @kessler-frost

@kessler-frost kessler-frost merged commit 8d22e7d into develop Jan 26, 2024
13 of 14 checks passed
@kessler-frost kessler-frost deleted the enable-qelectron-tests branch January 26, 2024 01:09
Andrew-S-Rosen added a commit to Quantum-Accelerators/quacc that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants