Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing notebooks #1900

Merged
merged 21 commits into from
Jan 8, 2024
Merged

Fixing notebooks #1900

merged 21 commits into from
Jan 8, 2024

Conversation

kessler-frost
Copy link
Member

@kessler-frost kessler-frost commented Jan 5, 2024

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (3e755ce) 84.49% compared to head (19d48b5) 84.49%.
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1900   +/-   ##
========================================
  Coverage    84.49%   84.49%           
========================================
  Files          295      295           
  Lines        14472    14472           
  Branches       195      195           
========================================
  Hits         12228    12228           
  Misses        2110     2110           
  Partials       134      134           
Flag Coverage Δ
Dispatcher 92.33% <0.00%> (ø)
Functional_Tests 51.38% <0.00%> (ø)
SDK 79.51% <100.00%> (ø)
UI_Backend 84.73% <ø> (ø)
UI_Frontend 73.35% <ø> (ø)

@kessler-frost kessler-frost changed the title Fixing file transfer notebooks Fixing notebooks Jan 7, 2024
@santoshkumarradha
Copy link
Member

Cc : @sriranjanivenkatesan a quick note for our docs once this is merged for notebook changes.

@kessler-frost kessler-frost marked this pull request as ready for review January 8, 2024 11:32
Copy link
Member

@santoshkumarradha santoshkumarradha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @kessler-frost gtg

@santoshkumarradha santoshkumarradha enabled auto-merge (squash) January 8, 2024 22:03
@cjao cjao disabled auto-merge January 8, 2024 22:30
@cjao cjao merged commit 2b8d2ca into develop Jan 8, 2024
13 of 14 checks passed
@cjao cjao deleted the fixing-notebooks branch January 8, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants