Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets: support range requests for alt representations #1890

Closed
wants to merge 1 commit into from

Conversation

cjao
Copy link
Contributor

@cjao cjao commented Dec 16, 2023

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

@cjao
Copy link
Contributor Author

cjao commented Dec 16, 2023

The changes here allow one to download a specific byte range of an asset's string representation. This may be useful for rendering large assets in the UI.

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Merging #1890 (37e9912) into develop (d94bdaf) will increase coverage by 0.50%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1890      +/-   ##
===========================================
+ Coverage    84.43%   84.93%   +0.50%     
===========================================
  Files          294      180     -114     
  Lines        14389    11180    -3209     
  Branches       195        0     -195     
===========================================
- Hits         12149     9496    -2653     
+ Misses        2106     1684     -422     
+ Partials       134        0     -134     
Flag Coverage Δ *Carryforward flag
Dispatcher 92.30% <100.00%> (-0.04%) ⬇️
Functional_Tests ?
SDK 79.27% <ø> (-0.04%) ⬇️ Carriedforward from d94bdaf
UI_Backend ?
UI_Frontend ?

*This pull request uses carry forward flags. Click here to find out more.

@cjao cjao marked this pull request as ready for review December 16, 2023 17:44
@cjao cjao requested a review from a team as a code owner December 16, 2023 17:44
@cjao cjao closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant