Unbreak task packing #1887
Closed
Unbreak task packing #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When submitting a task group, only attempt to upload task inputs corresponding to nodes external to the task group since only those will have been resolved.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1887 +/- ##
===========================================
+ Coverage 84.43% 84.48% +0.05%
===========================================
Files 294 295 +1
Lines 14389 14467 +78
Branches 195 195
===========================================
+ Hits 12149 12223 +74
- Misses 2106 2110 +4
Partials 134 134
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When submitting a task group, only attempt to upload task inputs corresponding to nodes external to the task group since only those will have been resolved.
This error was exposed by the recent change to stop uploading null attributes of electrons during dispatch. Previously the outputs of electrons -- even those that had not run yet -- were initialized to a non-null default value and then replaced during task execution.