Reduce the number of asset transfers during dispatch (1/2): omit null assets #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
cjao
force-pushed
the
slim-asset-uploads-1
branch
from
b08f550 to
0ece054
Compare
cjao
changed the title
cjao
force-pushed
the
slim-asset-uploads-1
branch
2 times, most recently
from
ef13c22 to
262c075
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1879 +/- ##
===========================================
+ Coverage 84.44% 84.48% +0.04%
===========================================
Files 294 294
Lines 14396 14435 +39
Branches 195 195
===========================================
+ Hits 12157 12196 +39
Misses 2105 2105
Partials 134 134
|
cjao
force-pushed
the
slim-asset-uploads-1
branch
4 times, most recently
from
08e427e to
f461ce6
Compare
Initialize unset assets to `None` and don' upload them. When downloading assets during `get_result()`, ignore assets with zero size. Also require asset sizes when retrieving asset updates in `Executor.receive()`.
cjao
force-pushed
the
slim-asset-uploads-1
branch
from
f461ce6 to
ea7aa65
Compare
FyzHsn
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize unset assets to
Noneand don' upload them.When downloading assets during
get_result(), ignore assets with zero size.Also require asset sizes when retrieving asset updates in
Executor.receive().Closes #1881