Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture terraform errors from deploy command, use scrolling buffer #1868

Merged
merged 34 commits into from
Nov 30, 2023

Conversation

araghukas
Copy link
Contributor

@araghukas araghukas commented Nov 29, 2023

Changed

  • Terraform output to use scrolling buffer.
  • Terraform output handling to show errors.

demo gif 1 (normal vs. verbose)

demo gif 2 (error example)


  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

@araghukas araghukas requested a review from a team as a code owner November 29, 2023 01:31
@araghukas araghukas marked this pull request as draft November 29, 2023 02:15
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #1868 (5b27d5d) into develop (6c9ce39) will increase coverage by 1.13%.
The diff coverage is 98.97%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1868      +/-   ##
===========================================
+ Coverage    83.81%   84.95%   +1.13%     
===========================================
  Files          293      180     -113     
  Lines        14371    11183    -3188     
  Branches       195        0     -195     
===========================================
- Hits         12045     9500    -2545     
+ Misses        2192     1683     -509     
+ Partials       134        0     -134     
Flag Coverage Δ
Dispatcher 92.23% <98.50%> (+1.41%) ⬆️
Functional_Tests ?
SDK 79.32% <100.00%> (+0.28%) ⬆️
UI_Backend ?
UI_Frontend ?

@araghukas araghukas marked this pull request as ready for review November 29, 2023 05:21
@araghukas
Copy link
Contributor Author

Sneaking in a quick fix for get_crm_object to get correct path in case of editable 'awsbatch' install.

  • The __import__ function gets the (empty) site-packages location in this case.
  • Instead importlib.import_module gets the correct path every time.

@kessler-frost kessler-frost merged commit 2e05b04 into develop Nov 30, 2023
14 checks passed
@kessler-frost kessler-frost deleted the capture-terraform-errors branch November 30, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants