-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hacktoberfest - Added a get all results function #1840
base: develop
Are you sure you want to change the base?
Conversation
Hello. You may have forgotten to update the changelog! |
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1840 +/- ##
===========================================
- Coverage 80.17% 78.38% -1.80%
===========================================
Files 232 128 -104
Lines 10239 7300 -2939
Branches 193 0 -193
===========================================
- Hits 8209 5722 -2487
+ Misses 1897 1578 -319
+ Partials 133 0 -133
*This pull request uses carry forward flags. Click here to find out more. |
Hey @Andrew-S-Rosen @wjcunningham7 Kindly review this PR that closes the above issue! |
Hi @Smartmind12 thanks for the PR. There are few changes needed before we can accept it. In your implementation you assume the Covalent server is running locally and directly interact with the results directory. This pattern is discouraged, in favor of an API-based approach. The client method in the Covalent SDK ( An example of a similar route can also be found in the front-end code, since the Covalent dashboard also performs a batch-get of dispatches (see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See other comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if ct
would be defined inside this function as ct
(I'm assuming) is the covalent package itself. Different implementation is required.
The get_all_results() function to retrieve all results, optionally filtered by a list of dispatch IDs, statuses, and timestamps. This provides more flexibility and control over the results you want to retrieve.
Could potentially close #1701