Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1835 #1837

Merged
merged 7 commits into from
Oct 19, 2023
Merged

fixes #1835 #1837

merged 7 commits into from
Oct 19, 2023

Conversation

kirill-push
Copy link
Contributor

@kirill-push kirill-push commented Oct 18, 2023

#1835

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

@kirill-push kirill-push requested a review from a team as a code owner October 18, 2023 15:38
@CLAassistant
Copy link

CLAassistant commented Oct 18, 2023

CLA assistant check
All committers have signed the CLA.

@kessler-frost kessler-frost linked an issue Oct 18, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #1837 (3853946) into develop (889bf3e) will decrease coverage by 1.60%.
Report is 3 commits behind head on develop.
The diff coverage is 94.07%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1837      +/-   ##
===========================================
- Coverage    80.17%   78.57%   -1.60%     
===========================================
  Files          232      128     -104     
  Lines        10239     7254    -2985     
  Branches       193        0     -193     
===========================================
- Hits          8209     5700    -2509     
+ Misses        1897     1554     -343     
+ Partials       133        0     -133     
Flag Coverage Δ *Carryforward flag
Dispatcher 81.90% <ø> (-4.47%) ⬇️ Carriedforward from d9d9256
Functional_Tests ?
SDK 77.70% <94.07%> (+2.87%) ⬆️
UI_Backend ?
UI_Frontend ?

*This pull request uses carry forward flags. Click here to find out more.

@kirill-push kirill-push marked this pull request as draft October 19, 2023 15:49
@kirill-push kirill-push marked this pull request as ready for review October 19, 2023 18:43
@kessler-frost
Copy link
Member

Hey @kirill-push could you try making another commit to this? Seems like the codecov check is bugged since it was passing earlier.

@kirill-push
Copy link
Contributor Author

Hey @kirill-push could you try making another commit to this? Seems like the codecov check is bugged since it was passing earlier.

Done

@wjcunningham7 wjcunningham7 merged commit 9540267 into AgnostiqHQ:develop Oct 19, 2023
11 of 12 checks passed
@kirill-push kirill-push deleted the electron_pow branch October 19, 2023 20:32
@kirill-push kirill-push restored the electron_pow branch October 23, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overloading the __pow__ method in Electron class
4 participants