Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily skipping the sqlite and database trigger functional tests #1809

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

kessler-frost
Copy link
Member

@kessler-frost kessler-frost commented Oct 11, 2023

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

Skipping the tests temporarily to unblock unrelated merges to develop. Related issue: #1808 .

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #1809 (a82443d) into develop (644bfb5) will increase coverage by 0.08%.
Report is 1 commits behind head on develop.
The diff coverage is 95.23%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1809      +/-   ##
===========================================
+ Coverage    80.08%   80.17%   +0.08%     
===========================================
  Files          231      232       +1     
  Lines        10180    10239      +59     
  Branches       193      193              
===========================================
+ Hits          8153     8209      +56     
- Misses        1894     1897       +3     
  Partials       133      133              
Flag Coverage Δ
Dispatcher 86.36% <83.33%> (-0.01%) ⬇️
Functional_Tests 51.83% <36.20%> (-0.14%) ⬇️
SDK 74.83% <100.00%> (+0.26%) ⬆️
UI_Backend 88.42% <60.00%> (-0.15%) ⬇️
UI_Frontend 73.43% <ø> (ø)

@kessler-frost kessler-frost marked this pull request as ready for review October 11, 2023 18:04
@kessler-frost kessler-frost requested a review from a team as a code owner October 11, 2023 18:04
@FyzHsn FyzHsn merged commit 0b19ae7 into develop Oct 11, 2023
12 checks passed
@FyzHsn FyzHsn deleted the skipping-db-trigger-functional-test branch October 11, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants