Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unassigned variable names #1796

Merged
merged 10 commits into from
Oct 2, 2023
Merged

Remove unassigned variable names #1796

merged 10 commits into from
Oct 2, 2023

Conversation

Andrew-S-Rosen
Copy link
Contributor

@Andrew-S-Rosen Andrew-S-Rosen commented Sep 29, 2023 •
edited
Loading

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

I removed unassigned variables 😄

@Andrew-S-Rosen Andrew-S-Rosen requested a review from a team as a code owner September 29, 2023 03:08
@codecov
Copy link

codecov bot commented Sep 29, 2023 •
edited
Loading

Codecov Report

Merging #1796 (f9b9f38) into develop (9e1c7d3) will decrease coverage by 1.98%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1796      +/-   ##
===========================================
- Coverage    80.08%   78.11%   -1.98%     
===========================================
  Files          231      116     -115     
  Lines        10180     6959    -3221     
  Branches       193        0     -193     
===========================================
- Hits          8153     5436    -2717     
+ Misses        1894     1523     -371     
+ Partials       133        0     -133
Flag Coverage Δ
Dispatcher 86.23% <100.00%> (-0.15%) ⬇️
Functional_Tests ?
SDK 74.53% <100.00%> (-0.03%) ⬇️
UI_Backend ?
UI_Frontend ?

@Andrew-S-Rosen Andrew-S-Rosen changed the title Minor code cleanup Remove unassigned variable names and use a TYPE_CHECKING block Sep 29, 2023
@Andrew-S-Rosen Andrew-S-Rosen changed the title Remove unassigned variable names and use a TYPE_CHECKING block Remove unassigned variable names Sep 29, 2023
@kessler-frost
Copy link
Member

Thanks for this @Andrew-S-Rosen 😄 !

kessler-frost
kessler-frost requested changes Oct 2, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Andrew-S-Rosen
Copy link
Contributor Author

@kessler-frost: Thanks for clarifying the purpose of "operations"! All fixed.

@kessler-frost kessler-frost merged commit 7967f16 into AgnostiqHQ:develop Oct 2, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kessler-frost kessler-frost kessler-frost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andrew-S-Rosen @kessler-frost