Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax the strict version pins for lmdbm, mpire, orjson, and pennylane #1795

Merged
merged 10 commits into from
Oct 3, 2023
Merged

Relax the strict version pins for lmdbm, mpire, orjson, and pennylane #1795

merged 10 commits into from
Oct 3, 2023

Conversation

Andrew-S-Rosen
Copy link
Contributor

@Andrew-S-Rosen Andrew-S-Rosen commented Sep 28, 2023 •
edited
Loading

This is a test to see if removing the version pin on orjson breaks things (also testing the others added in #1794).

Edit: anddddd success 🙏

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

@Andrew-S-Rosen Andrew-S-Rosen requested a review from a team as a code owner September 28, 2023 18:20
@Andrew-S-Rosen Andrew-S-Rosen changed the title [WIP] Remove version pin on orjson Relax the version pins again Sep 28, 2023
@Andrew-S-Rosen Andrew-S-Rosen changed the title Relax the version pins again [WIP] Relax the version pins again Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

Merging #1795 (06be320) into develop (6885bb2) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1795   +/-   ##
========================================
  Coverage    80.08%   80.08%           
========================================
  Files          231      231           
  Lines        10179    10179           
  Branches       193      193           
========================================
  Hits          8152     8152           
  Misses        1894     1894           
  Partials       133      133
Flag Coverage Δ
Dispatcher 86.37% <ø> (ø)
Functional_Tests 51.97% <ø> (ø)
SDK 74.56% <ø> (ø)
UI_Backend 88.57% <ø> (ø)
UI_Frontend 73.43% <ø> (ø)

@Andrew-S-Rosen
Copy link
Contributor Author

@kessler-frost: Looks like this passed. I'm going to update the CHANGELOG. Feel free to propose any changes from here.

@Andrew-S-Rosen Andrew-S-Rosen changed the title [WIP] Relax the version pins again Relax the version pins again Sep 28, 2023
@Andrew-S-Rosen Andrew-S-Rosen changed the title Relax the version pins again Relax the strict version pins for lmdbm, mpire, orjson, and pennylane Sep 29, 2023
kessler-frost
kessler-frost requested changes Oct 2, 2023
View reviewed changes
Copy link
Member

@kessler-frost kessler-frost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Andrew-S-Rosen ! Just a minor comment.

CHANGELOG.md Outdated Show resolved Hide resolved
@Andrew-S-Rosen
Copy link
Contributor Author

@kessler-frost: Thanks! I agree about the CHANGELOG category change. All fixed!

@AlejandroEsquivel AlejandroEsquivel merged commit bfe3c35 into AgnostiqHQ:develop Oct 3, 2023
12 checks passed
@Andrew-S-Rosen Andrew-S-Rosen deleted the patch-2 branch October 3, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kessler-frost kessler-frost kessler-frost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Andrew-S-Rosen @kessler-frost @AlejandroEsquivel