-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update requirements.txt
to update pydantic minimum version and put py.typed
in MANIFEST.in
#1767
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1767 +/- ##
========================================
Coverage 88.21% 88.21%
========================================
Files 191 191
Lines 8222 8222
Branches 151 151
========================================
Hits 7253 7253
Misses 864 864
Partials 105 105
|
@arosen93 thanks a lot for identifying the exact cause ! This could have been quite nasty to debug sans UI logs ! @kessler-frost can you take a look at this please 🙏🏻 |
Upgrading Pydantic might break certain things I believe (hopefully I'm wrong), but let's see what happens. This PR looks gtg from my side. |
🙏 |
requirements.txt
to update pydantic minimum version and put py.typed
in MANIFEST.in
@kessler-frost: I added the |
Just a heads up to the team Pydantic 2 has been known to not work on AWS Lambda, so keep an eye out for this during the next round of QA |
There also is a case where pydantic 2 has been supported only for fastapi versions > 100. So we might need to tweak the fastapi limits in the requirements as well. (Currently <100 also can be installed) Also when we install fastapi, pydantic gets installed automatically with a fastapi compatible version. So we might need to set both the fastapi and pydantic version correctly to avoid any failures. cc : @kessler-frost @arosen93 @wjcunningham7 |
Closes #1765. Essentially, the existing minimum version for Pydantic causes the UI not to render appropriately. Pydantic > 2 is needed now for Covalent. As such, I have set the minimum version to 2.1.1. I chose 2.1.1 intentionally because: a) I tested it and it works; b) FastAPI strictly does not support 2.0.0, 2.0.1, or 2.1.0 so we can't use 2.0 through 2.1.0 anyway.