Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trigger-enhancements-for-dt #1734

Merged
merged 13 commits into from
Oct 5, 2023
Merged

trigger-enhancements-for-dt #1734

merged 13 commits into from
Oct 5, 2023

Conversation

wjcunningham7
Copy link
Member

@wjcunningham7 wjcunningham7 commented Jul 25, 2023 •
edited by Prasy12
Loading

The purpose of this PR is to support Postgres as a database trigger

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

@wjcunningham7 wjcunningham7 self-assigned this Jul 25, 2023
@wjcunningham7 wjcunningham7 added feature New feature addition improvement Enhancement to style or performance labels Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023 •
edited
Loading

Codecov Report

Merging #1734 (98a356b) into develop (644bfb5) will decrease coverage by 0.30%.
The diff coverage is 95.23%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1734      +/-   ##
===========================================
- Coverage    80.08%   79.79%   -0.30%     
===========================================
  Files          231      147      -84     
  Lines        10180     8244    -1936     
  Branches       193        0     -193     
===========================================
- Hits          8153     6578    -1575     
+ Misses        1894     1666     -228     
+ Partials       133        0     -133
Flag Coverage Δ
Dispatcher 86.22% <83.33%> (-0.15%) ⬇️
Functional_Tests ?
SDK 74.81% <100.00%> (+0.24%) ⬆️
UI_Backend 88.42% <60.00%> (-0.15%) ⬇️
UI_Frontend ?

@santoshkumarradha santoshkumarradha added Team Psi Covalent Team Psi Team Psi - BE Covalent Team Psi BE labels Aug 30, 2023
@santoshkumarradha
Copy link
Member

santoshkumarradha commented Sep 4, 2023 •
edited by ArunPsiog
Loading

Left over items

  • documentation
    • adding in features page trigger and also api and how to
  • Tests

@Prasy12 Prasy12 assigned ArunPsiog and unassigned wjcunningham7 Sep 7, 2023
kessler-frost
kessler-frost reviewed Sep 13, 2023
View reviewed changes
covalent_dispatcher/_triggers_app/app.py Outdated Show resolved Hide resolved
covalent/triggers/base.py Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@Prasy12 Prasy12 marked this pull request as ready for review September 26, 2023 14:39
@Prasy12 Prasy12 requested review from a team and santoshkumarradha as code owners September 26, 2023 14:39
kessler-frost
kessler-frost previously approved these changes Sep 27, 2023
View reviewed changes
@santoshkumarradha santoshkumarradha merged commit 265092f into develop Oct 5, 2023
12 checks passed
@santoshkumarradha santoshkumarradha deleted the trigger-enhancements-for-dt branch October 5, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArunPsiog ArunPsiog ArunPsiog left review comments

@santoshkumarradha santoshkumarradha santoshkumarradha approved these changes

@kessler-frost kessler-frost kessler-frost left review comments

Assignees

@ArunPsiog ArunPsiog

Labels
feature New feature addition improvement Enhancement to style or performance Team Psi - BE Covalent Team Psi BE Team Psi Covalent Team Psi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wjcunningham7 @santoshkumarradha @kessler-frost @ArunPsiog @Prasy12