Memory improvements (3/3): Introduce new runner and executor API #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjao
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1690 +/- ##
===========================================
+ Coverage 80.17% 84.00% +3.83%
===========================================
Files 232 290 +58
Lines 10239 14120 +3881
Branches 193 193
===========================================
+ Hits 8209 11862 +3653
- Misses 1897 2125 +228
Partials 133 133
|
cjao
force-pushed
the
os-enhancements-preview-testmerge
branch
from
409c717 to
d3ef226
Compare
cjao
force-pushed
the
os-enhancements-preview-testmerge
branch
3 times, most recently
from
0bd0220 to
feedf10
Compare
cjao
force-pushed
the
os-enhancements-preview-testmerge
branch
2 times, most recently
from
e299df8 to
ba0a78e
Compare
cjao
force-pushed
the
os-enhancements-preview-testmerge
branch
10 times, most recently
from
7c3ce70 to
3d3258e
Compare
cjao
changed the title
3 tasks
|
This PR completes the series on memory usage improvements and builds on #1729 . It introduces a new runner to submit tasks and retrieve their results without loading the task's assets in memory. The runner also operates on task groups, not just individual tasks. To use the new runner, each executor plugin must implement a new API for running task groups. If a task's executor plugin does not opt into the new API, Covalent will attempt to fall back to the existing in-memory runner. |
cjao
force-pushed
the
os-enhancements-preview-testmerge
branch
3 times, most recently
from
459fd89 to
5125bcf
Compare
|
Converting to draft to add more tests. |
cjao
force-pushed
the
os-enhancements-preview-testmerge
branch
from
56eb13d to
6701bb0
Compare
cjao
force-pushed
the
os-enhancements-preview-testmerge
branch
4 times, most recently
from
ecd5ee5 to
4f9d12a
Compare
Running `covalent start` causes the config file to be updated from two processes: * the CLI runner, after `_graceful_start()` returns, and * the DaskCluster process, which records the cluster state after the cluster starts up. Unfortunately, the CLI runner previously wrote out the config it loaded into memory before starting the dispatcher process. Its ConfigManager instance was therefore unaware of any config file updates that might have happened before `_graceful_start()` returned. If the Dask cluster were to finish starting up and write out its state before the CLI runner returned from `_graceful_start()`, the CLI's config file update would obliterate the Dask cluster info. This patch refreshes the CLI app's ConfigManager instance from the on-disk config file after `_graceful_start()` and ensures that the Dask cluster finishes starting before `_graceful_start()` returns.
cjao
force-pushed
the
os-enhancements-preview-testmerge
branch
from
4f9d12a to
31f0479
Compare
kessler-frost
approved these changes
Nov 9, 2023
wjcunningham7
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/AgnostiqHQ/covalent-staging/issues/709