Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version change for aws provider #69

Merged
merged 2 commits into from
Oct 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [UNRELEASED]

### Changed

- Updated the terraform provider version for AWS to 5.17.0 (ecs plugin)
- Disabled `enable_nat_gateway` on the vpc module, since it was throwing error from the respective module

### Added
- Added ownership controls for S3 bucket for supporting S3 bucket ACL

## [0.31.0] - 2023-09-20

### Changed
Expand Down
13 changes: 11 additions & 2 deletions covalent_ecs_plugin/assets/infra/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,18 @@ resource "aws_s3_bucket" "bucket" {
force_destroy = true
}

resource "aws_s3_bucket_acl" "bucket_acl" {
resource "aws_s3_bucket_ownership_controls" "ownership_controls" {
bucket = aws_s3_bucket.bucket.id
acl = "private"

rule {
object_ownership = "BucketOwnerPreferred"
}
}

resource "aws_s3_bucket_acl" "bucket_acl" {
depends_on = [aws_s3_bucket_ownership_controls.ownership_controls]
bucket = aws_s3_bucket.bucket.id
acl = "private"
}

resource "aws_ecr_repository" "ecr_repository" {
Expand Down
2 changes: 1 addition & 1 deletion covalent_ecs_plugin/assets/infra/networking.tf
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ module "vpc" {
]
private_subnets = []

enable_nat_gateway = true
enable_nat_gateway = false
single_nat_gateway = false
enable_dns_hostnames = true
}
Expand Down
2 changes: 1 addition & 1 deletion covalent_ecs_plugin/assets/infra/versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = "~> 4.23"
version = "5.17.0"
}
}
}
Loading