Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Tool packages #76

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

WIP Tool packages #76

wants to merge 9 commits into from

Conversation

tcdent
Copy link
Collaborator

@tcdent tcdent commented Dec 2, 2024

Idea here is that all of the tool-specific implementation (including config JSON) lives in one directory.

Dependencies move from the JSON file into a pyproject.toml file, which also breaks out any framework-specific dependencies, like the version of CrewAI it uses, into a tag under optional-dependencies.

We still need to discuss a preferred package manager so I dove into to the docs of the top four and put together some possible commands. uv and pip do what we need out of the box. poetry can still help us with dependencies, but copying the actual source files rolls back to a manual copy. conda would be similar to pip, since we'd probably just fall back to pip in that case; it doesn't have any CLI flags for this kind of conditional copying nor does it really support pyproject.toml.

agent_connect is the only tool dir that I reorganized so far to reflect this new structure.

Would be cool to explicitly specify a preferred package manager in agentstack.json if we do go with multiple managers.

Needs tests before merge as well.

This addresses #43

@tcdent tcdent requested a review from bboynton97 December 2, 2024 00:46
@tcdent tcdent marked this pull request as draft December 2, 2024 17:05
@bboynton97
Copy link
Contributor

lets save this for 0.3 because it will require the project upgrade script. we can merge it now though and create a 0.2 branch for bug fixes and small features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants