Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GST sentence parser #121

Merged
merged 3 commits into from
May 5, 2024
Merged

Add GST sentence parser #121

merged 3 commits into from
May 5, 2024

Conversation

zhrbrk
Copy link
Contributor

@zhrbrk zhrbrk commented Mar 11, 2024

#54 Add GST sentence parser with unit test.
GST is now a stand-alone feature, and also added into the GNSS features package.

"GST" feature is also added to the "GNSS" features package.

Signed-off-by: zhrbrk <[email protected]> <[email protected]>
Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the PR!
I have a few comments on the doc comments.
Can you also make sure you use /// doc comments instead of regular // comments for the struct?

I will give it a more thorough look sometime later this week, in the meantime I will run the CI.

Comment on lines 17 to 19
// 1 2 3 4 5 6 7 8 9
// | | | | | | | | |
// $ --GST,hhmmss.ss,x,x,x,x,x,x,x*hh<CR><LF>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// 1 2 3 4 5 6 7 8 9
// | | | | | | | | |
// $ --GST,hhmmss.ss,x,x,x,x,x,x,x*hh<CR><LF>
/// ```text
/// 1 2 3 4 5 6 7 8 9
/// | | | | | | | | |
/// $ --GST,hhmmss.ss,x,x,x,x,x,x,x*hh<CR><LF>
/// ```

// | | | | | | | | |
// $ --GST,hhmmss.ss,x,x,x,x,x,x,x*hh<CR><LF>
//
// Example: $GPGST,182141.000,15.5,15.3,7.2,21.8,0.9,0.5,0.8*54
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Example: $GPGST,182141.000,15.5,15.3,7.2,21.8,0.9,0.5,0.8*54
/// Example: `$GPGST,182141.000,15.5,15.3,7.2,21.8,0.9,0.5,0.8*54`

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 77.78%. Comparing base (af2edeb) to head (b15db1c).
Report is 1 commits behind head on main.

❗ Current head b15db1c differs from pull request most recent head 61f33ee. Consider uploading reports for the commit 61f33ee to get more accurate results

Files Patch % Lines
src/sentences/gst.rs 87.50% 3 Missing ⚠️
src/parser.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   77.62%   77.78%   +0.16%     
==========================================
  Files          34       35       +1     
  Lines        1247     1274      +27     
==========================================
+ Hits          968      991      +23     
- Misses        279      283       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced May 5, 2024
@elpiel elpiel merged commit 24af86b into AeroRust:main May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants