Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More BufferIDs & scroll (de)serializatoin #7

Merged
merged 16 commits into from
May 3, 2020

Conversation

elpiel
Copy link
Member

@elpiel elpiel commented May 1, 2020

  • added scroll
  • impled for all types:
    • scroll::ctx::TryFromCtx
    • scroll::ctx::TryIntoCtx

@elpiel elpiel changed the title More BufferIDs More BufferIDs & scroll (de)serializatoin May 1, 2020
Copy link
Member

@o0Ignition0o o0Ignition0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to take that one for a spin this afternoon, thanks a lot ! 🎉

take_off.to_le_bytes().to_vec()
fn try_into_ctx(self, this: &mut [u8], ctx: Endian) -> Result<usize, Self::Error> {
// TODO: Fix when we have more options
Ok(this.pwrite_with::<u16>(self as u16, 0, ctx)?)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@o0Ignition0o o0Ignition0o merged commit 3f01641 into master May 3, 2020
@o0Ignition0o o0Ignition0o deleted the tweaks-and-scroll-wips branch May 3, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants