Add support for AdminRequest Sessions
#25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @amcalgates, Thank you so much for taking the time to contribute to our repository. Regards, |
kaphacius
reviewed
Sep 5, 2023
- Add `OperationVariant` enum - Add comment stubs for inits to match rest of code base - Fix spacing in variable declarations - Capitalize first word in comments
|
I've made all requested changes, except for one comment I was unsure on (see my inline replies). |
kaphacius
reviewed
Sep 11, 2023
|
I've made most of the requested changes, and left comments in areas I need more clarification on. |
|
@kaphacius - any follow-up on my comments? |
|
hey @amcalgates |
kaphacius
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for
AdminRequestBegin/End session as seen in Create a session documentation.All added classes/additions mirror the naming found in that documentation, however I had to introduce a new class which I named
SessionContainerto combine theSessionand[Operation]objects for JSON serialization, which can then be base64 encoded to a string and used forAdminRequest.ServiceIdentificationPlease let me know if you'd prefer a different name for
SessionContainer- I couldn't find a similar concept in adyen-terminal-api-ios to base the naming off of.Tested scenarios
I've tested this with both Begin and End session calls using an AMS1 device.