Remove invoice send without config check #2814
Open
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove sending of the invoice email without former check if invoice emails are enabled.
|
Hello @aschrammel, Thank you for your contribution. We will check the PR and merge it if there is no issue. Best Regards, |
acampos1916
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently invoice emails are sent without checking the corresponding configuration value and than a second time if the configuration for invoice emails is active after checking the flag when processing webhooks.
Desired behavior is, that no invoice emails are sent out in case he corresponding configuration flag is inactive.
Tested scenarios
Order invoice email on webhook processing is only sent out when invoice emails should be sent according to Magento configuration.