Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-9476]Updating Paybylink description for Magento Orders #2810

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −7
Open

[ECP-9476]Updating Paybylink description for Magento Orders #2810

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c4bb89
Updating Paybylink description
khushboo-singhvi Nov 21, 2024
1049c54
Merge branch 'main' into ECP-9476
khushboo-singhvi Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions Gateway/Request/DescriptionDataBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,7 @@ public function build(array $buildSubject)
$payment = $paymentDataObject->getPayment();
/** @var Order $order */
$order = $payment->getOrder();

$request['body']['description'] = __(
'Order %1 from %2',
$order->getIncrementId(),
$order->getStore()->getGroup()->getName()
);

$request['body']['description'] = 'Order ' . $order->getIncrementId() . ' from ' . $order->getStore()->getGroup()->getName();
Copy link
Member

@candemiralp candemiralp Nov 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will lose the localisation capabilities after removing the phrase and merchants will not be able to add translation. Do we know why this is an issue now especially after migrating to model based library?

return $request;
}
}
Loading