[ECP-9534] Fix success page displayed if payment is canceled #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
had a problem deploying
to
internal
GitHub Actions
Failure
khushboo-singhvi
had a problem deploying
to
internal
GitHub Actions
Error
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
had a problem deploying
to
internal
GitHub Actions
Failure
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
had a problem deploying
to
internal
GitHub Actions
Failure
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
had a problem deploying
to
internal
GitHub Actions
Failure
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
|
candemiralp
approved these changes
Nov 4, 2024
peterojo
approved these changes
Nov 4, 2024
Merged
This was
linked to
issues
Nov 4, 2024
This was referenced Nov 4, 2024
Closed
candemiralp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
isResponseAlreadyProcessed() method has been introduces to solve issues related the duplicate /payments/details API calls. However, relying on the order comment history is not a robust solution. Moreover, this solution has a bug reported in the given Github Issue.
The end goal of ECP-9261 (where
isResponseAlreadyProcessed()was introduced) was preventing order state change after making duplicate/payments/detailscall. This issue has already handled in this PR, so we can get rid ofisResponseAlreadyProcessed()Tested scenarios
Fixes
#2777
#2775
#2786