Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-9398] Solving the issue of inconsistency of Order state and status field #2727

Merged
merged 2 commits into from
Sep 16, 2024
Merged

[ECP-9398] Solving the issue of inconsistency of Order state and status field #2727

merged 2 commits into from
Sep 16, 2024

Conversation

khushboo-singhvi
Copy link
Contributor

@khushboo-singhvi khushboo-singhvi commented Sep 2, 2024 •
edited
Loading

Description
Adding check in OFFER_CLOSE webhook process that if the order is already in canceled state, then do not update the state to new and proceed with cancel

Tested scenarios

Fixes

@khushboo-singhvi khushboo-singhvi marked this pull request as ready for review September 6, 2024 13:43
@khushboo-singhvi khushboo-singhvi requested a review from a team as a code owner September 6, 2024 13:43
@khushboo-singhvi khushboo-singhvi changed the title Solving the issue of inconsistency of Order state and status field af… Solving the issue of inconsistency of Order state and status field Sep 6, 2024
@khushboo-singhvi khushboo-singhvi changed the title Solving the issue of inconsistency of Order state and status field [ECP-9398]Solving the issue of inconsistency of Order state and status field Sep 6, 2024
@candemiralp candemiralp changed the title [ECP-9398]Solving the issue of inconsistency of Order state and status field [ECP-9398] Solving the issue of inconsistency of Order state and status field Sep 9, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@khushboo-singhvi khushboo-singhvi merged commit 4d4406a into main Sep 16, 2024
16 checks passed
@khushboo-singhvi khushboo-singhvi deleted the ECP-9398 branch September 16, 2024 13:44
@github-actions github-actions bot mentioned this pull request Sep 16, 2024
Merged
@RokPopov RokPopov added the Fix Indicates a bug fix label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SushmitaThakur SushmitaThakur SushmitaThakur approved these changes

@candemiralp candemiralp candemiralp approved these changes

Assignees
No one assigned
Labels
Fix Indicates a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khushboo-singhvi @candemiralp @SushmitaThakur @RokPopov