Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-9408] Fix handling Giftcard payments responses #2724

Merged
merged 35 commits into from
Sep 11, 2024
Merged

[ECP-9408] Fix handling Giftcard payments responses #2724

merged 35 commits into from
Sep 11, 2024

Conversation

SushmitaThakur
Copy link
Contributor

@SushmitaThakur SushmitaThakur commented Aug 26, 2024 •
edited
Loading

Description
This PR fixes partial payment with one or more giftcards + a final non-giftcard PM responses for the shopper to land on the correct page.

  1. This fix also ensures that processGiftcards() now includes all giftcard responses, rather than just the last one. Previously, handleGiftcards() returned only the final giftcard response (whether successful or failed) when handling multiple giftcards. It also includes a unit test for checking the response type for multiple giftcard scenario.

  2. The CheckoutResponse validator and handler classes are modified to handle an array of responses.

  3. New Unit tests added for the following classes -

  • CheckoutResponseValidator
  • CheckoutPaymentCommentHistoryHandler
  • CheckoutPaymentsDetailsHandler
  • CheckoutPaymentCommentHistoryHandler

** Manually Tested scenarios**

  1. Payment with a single gift card with correct details - should succeed
  2. Payment with a single gift card with incorrect details - should fail
  3. Payment with two gift cards, one with correct details, one with incorrect details - should fail
  4. Payment with one gift card with correct details and credit card with correct details - should succeed
  5. Payment with one gift card with incorrect details and credit card with correct details - should fail
  6. Payment with two gift cards, one with correct details, one with incorrect details and one credit card with correct details - should fail

[ECP-9408] Fix the payment response if one of the payments has failed…
82acd1d 
… in case of partial payments, also fix the processGiftcard response to include all the giftcard processings
@SushmitaThakur SushmitaThakur requested a review from a team as a code owner August 26, 2024 20:22
[ECP-9408] Add unit tests for multiple giftcard payment responses, up…
6fa1a09 
…date the existing one for when there is no gift cars and the array is empty
candemiralp
candemiralp previously requested changes Aug 27, 2024
View reviewed changes
Gateway/Http/Client/TransactionPayment.php Outdated Show resolved Hide resolved
Gateway/Http/Client/TransactionPayment.php Outdated Show resolved Hide resolved
Gateway/Http/Client/TransactionPayment.php Show resolved Hide resolved
Gateway/Http/Client/TransactionPayment.php Show resolved Hide resolved
[ECP-9408] Transaction payment returns array of responses, modified t…
6a4f7ea 
…ests accordingly, remove class type assert for multiple giftcard response test, add the foreach for verifying payments in CheckoutResponseValidator
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 10, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
92.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SushmitaThakur SushmitaThakur changed the title [ECP-9408] Fix failing Giftcard payments response not checked before redirecting shopper [ECP-9408] Fix handling Giftcard payments responses Sep 11, 2024
@SushmitaThakur SushmitaThakur merged commit 5511ac0 into main Sep 11, 2024
16 checks passed
@SushmitaThakur SushmitaThakur deleted the ECP-9408 branch September 11, 2024 13:30
@github-actions github-actions bot mentioned this pull request Sep 11, 2024
Merged
@RokPopov RokPopov added the Fix Indicates a bug fix label Sep 17, 2024
@candemiralp candemiralp mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candemiralp candemiralp candemiralp approved these changes

@peterojo peterojo peterojo approved these changes

Assignees
No one assigned
Labels
Fix Indicates a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SushmitaThakur @peterojo @candemiralp @RokPopov