Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-9112] Fix broken feature of obtaining state data from DB #2583

Merged
merged 8 commits into from
Apr 18, 2024
Merged

[ECP-9112] Fix broken feature of obtaining state data from DB #2583

merged 8 commits into from
Apr 18, 2024

Conversation

khushboo-singhvi
Copy link
Contributor

@khushboo-singhvi khushboo-singhvi commented Apr 11, 2024 •
edited
Loading

Description
obtaining state data from DB and ignoring it for Giftcard type payment methods

Tested scenarios

  • Card payment can be completed with a stored state data.
  • Single gift card payment can be completed with a stored state data.
  • Gift card payments though graphql can be completed (card + giftcard)
  • Gift card payment can be completed without saving the state data to the DB (pass in the additional information)

Fixes
#2573

@khushboo-singhvi khushboo-singhvi requested a review from a team as a code owner April 11, 2024 14:42
RokPopov
RokPopov previously approved these changes Apr 11, 2024
View reviewed changes
candemiralp
candemiralp previously approved these changes Apr 12, 2024
View reviewed changes
@candemiralp candemiralp self-requested a review April 12, 2024 07:09
@khushboo-singhvi khushboo-singhvi linked an issue Apr 12, 2024 that may be closed by this pull request
[ECP-9112] 9.4.x break *DataAssignObserver and placeOrder #2573
Closed
@khushboo-singhvi khushboo-singhvi dismissed stale reviews from candemiralp and RokPopov via c806ece April 15, 2024 14:41
@RokPopov RokPopov mentioned this pull request Apr 16, 2024
Merged
@RokPopov RokPopov added the Fix Indicates a bug fix label Apr 17, 2024
@RokPopov RokPopov merged commit d5e4c51 into develop Apr 18, 2024
8 of 10 checks passed
@RokPopov RokPopov deleted the ECP-9112 branch April 18, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RokPopov RokPopov RokPopov approved these changes

@peterojo peterojo peterojo approved these changes

@candemiralp candemiralp Awaiting requested review from candemiralp

Assignees
No one assigned
Labels
Fix Indicates a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ECP-9112] 9.4.x break *DataAssignObserver and placeOrder
4 participants
@khushboo-singhvi @peterojo @candemiralp @RokPopov