Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECP-8984] Remove version from data patches and setup_version from module.xml #2567

Merged
merged 6 commits into from
Apr 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions Setup/Patch/Data/CreateStatusAuthorized.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,14 @@
use Magento\Framework\Exception\AlreadyExistsException;
use Magento\Framework\Setup\ModuleDataSetupInterface;
use Magento\Framework\Setup\Patch\DataPatchInterface;
use Magento\Framework\Setup\Patch\PatchVersionInterface;
use Magento\Framework\App\Config\ReinitableConfigInterface;
use Magento\Framework\App\Config\Storage\WriterInterface;
use Magento\Sales\Model\Order;
use Magento\Sales\Model\Order\StatusFactory;
use Magento\Sales\Model\ResourceModel\Order\StatusFactory as StatusResourceFactory;
use Magento\Sales\Model\ResourceModel\Order\Status as StatusResource;

class CreateStatusAuthorized implements DataPatchInterface, PatchVersionInterface
class CreateStatusAuthorized implements DataPatchInterface
{
private ModuleDataSetupInterface $moduleDataSetup;
private WriterInterface $configWriter;
Expand Down Expand Up @@ -103,9 +102,4 @@ public static function getDependencies(): array
{
return [];
}

public static function getVersion(): string
{
return '9.0.3';
}
}
10 changes: 1 addition & 9 deletions Setup/Patch/Data/CreditCardsBecomeCards.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
use Magento\Framework\Setup\Patch\DataPatchInterface;
use Magento\Framework\Setup\Patch\PatchVersionInterface;

class CreditCardsBecomeCards implements DataPatchInterface, PatchVersionInterface
class CreditCardsBecomeCards implements DataPatchInterface
{
private ModuleDataSetupInterface $moduleDataSetup;

Expand Down Expand Up @@ -65,12 +65,4 @@ public static function getDependencies()
{
return [];
}

/**
* @inheritDoc
*/
public static function getVersion()
{
return '9.0.5';
}
}
8 changes: 1 addition & 7 deletions Setup/Patch/Data/RatepayIdConfiguration.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@
use Magento\Framework\App\Config\Storage\WriterInterface;
use Magento\Framework\Setup\ModuleDataSetupInterface;
use Magento\Framework\Setup\Patch\DataPatchInterface;
use Magento\Framework\Setup\Patch\PatchVersionInterface;

class RatepayIdConfiguration implements DataPatchInterface, PatchVersionInterface
class RatepayIdConfiguration implements DataPatchInterface
{
private ModuleDataSetupInterface $moduleDataSetup;
private WriterInterface $configWriter;
Expand Down Expand Up @@ -96,9 +95,4 @@ public static function getDependencies(): array
{
return [];
}

public static function getVersion(): string
{
return '9.0.0';
}
}
15 changes: 1 addition & 14 deletions Setup/Patch/Data/RemoveMinMaxOrderConfigMigration.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,18 @@

namespace Adyen\Payment\Setup\Patch\Data;

use Magento\Framework\App\Config\ReinitableConfigInterface;
use Magento\Framework\Setup\ModuleDataSetupInterface;
use Magento\Framework\Setup\Patch\DataPatchInterface;
use Magento\Framework\Setup\Patch\PatchVersionInterface;

class RemoveMinMaxOrderConfigMigration implements DataPatchInterface, PatchVersionInterface
class RemoveMinMaxOrderConfigMigration implements DataPatchInterface
{
private ModuleDataSetupInterface $moduleDataSetup;
private ReinitableConfigInterface $reinitableConfig;

public function __construct(
ModuleDataSetupInterface $moduleDataSetup,
ReinitableConfigInterface $reinitableConfig
)
{
$this->moduleDataSetup = $moduleDataSetup;
$this->reinitableConfig = $reinitableConfig;
}

/**
Expand Down Expand Up @@ -67,12 +62,4 @@ public static function getDependencies()
{
return [];
}

/**
* @inheritDoc
*/
public static function getVersion()
{
return '9.0.0';
}
}
1 change: 0 additions & 1 deletion Setup/Patch/Data/VaultMigration.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
use Magento\Framework\Setup\ModuleDataSetupInterface;
use Magento\Framework\Setup\Patch\DataPatchInterface;
use Magento\Vault\Api\Data\PaymentTokenFactoryInterface;
use Magento\Vault\Api\Data\PaymentTokenInterface;
use Magento\Vault\Api\PaymentTokenManagementInterface;
use Magento\Vault\Api\PaymentTokenRepositoryInterface;

Expand Down
2 changes: 1 addition & 1 deletion etc/module.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">

<module name="Adyen_Payment" setup_version="9.4.0">
<module name="Adyen_Payment">
<sequence>
<module name="Magento_Sales"/>
<module name="Magento_Quote"/>
Expand Down
Loading