Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pay by Bank US - Confirmation Pop-up #1908

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

ozgur00
Copy link
Contributor

@ozgur00 ozgur00 commented Nov 29, 2024

Description

Display confirmation pop-up in PreselectedStoredPaymentMethodFragment and include bank account name as message in the pop-up for Pay by Bank US.

Checklist

  • PR is labelled
  • Code is unit tested
  • Changes are tested manually

COAND-974

@ozgur00 ozgur00 added the Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes label Nov 29, 2024
@ozgur00 ozgur00 requested a review from a team as a code owner November 29, 2024 14:42
@ozgur00 ozgur00 force-pushed the feature/pay-by-bank-us-stored-popup branch from 883d0a8 to 3a20952 Compare December 2, 2024 09:52
@ozgur00 ozgur00 force-pushed the feature/pay-by-bank-us-stored-popup branch from 3a20952 to b4ec804 Compare December 2, 2024 10:05
Copy link

github-actions bot commented Dec 2, 2024

✅ No public API changes

Copy link

sonarcloud bot commented Dec 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
23.3% Coverage on New Code (required ≥ 80%)
11.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@ozgur00 ozgur00 merged commit 4656599 into feature/pay-by-bank-us Dec 2, 2024
8 of 9 checks passed
@ozgur00 ozgur00 deleted the feature/pay-by-bank-us-stored-popup branch December 2, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants