Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release - Update the script to check for release notes based on PR label #1905

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Release - Update the script to check for release notes based on PR label #1905

merged 3 commits into from
Dec 3, 2024

Conversation

araratthehero
Copy link
Contributor

Description

  • Added a new script to check for release notes in the PR body
  • Adjusted the old check_labels script
  • Created two list for required and optional labels, which define if release notes should be present or not

Here are workflow runs for all possible cases

Release notes exist

Case Status (should pass or not pass)
No label added ❌ (label required)
Has required label (Fix) ✅
Has optional label (Dependencies) ✅

Release notes do not exist

Case Status (should pass or not pass)
No label added ❌ (label required)
Has required label (Fix) ❌ (release notes required)
Has optional label (Dependencies) ✅

Checklist

  • PR is labelled
  • Changes are tested manually

COAND-1016

@araratthehero araratthehero added the Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes label Nov 28, 2024
@araratthehero araratthehero requested a review from a team as a code owner November 28, 2024 14:27
Base automatically changed from chore/release_process_changes_open_release_notes_pr to chore/release_process_changes December 2, 2024 09:32
@araratthehero araratthehero force-pushed the chore/release_process_changes_check_release_notes_based_on_label branch from 41461a3 to 37645eb Compare December 3, 2024 08:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

✅ No public API changes

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@araratthehero araratthehero merged commit d86d0ea into chore/release_process_changes Dec 3, 2024
11 checks passed
@araratthehero araratthehero deleted the chore/release_process_changes_check_release_notes_based_on_label branch December 3, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OscarSpruit OscarSpruit OscarSpruit approved these changes

Assignees
No one assigned
Labels
Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@araratthehero @OscarSpruit