Fix address fetch crash (v4) #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreij
approved these changes
Aug 31, 2023
Before it would crash. Now when fetching countries fails we notify the merchant and display a dialog to the shopper. This should prevent the shopper from proceeding to the empty states list. COAND-777
We are mapping country codes the this enum's entries. This will not work if the enum is obfuscated. COAND-777
OscarSpruit
force-pushed
the
fix/address_crash
branch
from
ba56557 to
31b1dd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return empty list when fetching country or states fails. Before it would crash. Now when fetching countries fails we notify the merchant and display a dialog to the shopper. This should prevent the shopper from proceeding to the empty states list.
Keep AddressSpecification from being obfuscated. We are mapping country codes the this enum's entries. This will not work if the enum is obfuscated.
Checklist
COAND-777