Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Short Array Notation in env.php Example #135

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

pykettk
Copy link
Contributor

@pykettk pykettk commented Sep 28, 2024

Purpose of this pull request

This pull request (PR) replaces the array() notation used in the example env.php snippet with the short [] notation to ease readability and reflect how the file will actually look to users.

Affected pages

@jeff-matthews jeff-matthews self-assigned this Sep 30, 2024
@jeff-matthews jeff-matthews added the technical Updates to the code or processes that alter the technical content of the doc label Sep 30, 2024
@jeff-matthews
Copy link
Contributor

@devops-devdocs import the pr

@jeff-matthews
Copy link
Contributor

Thanks for the PR @pykettk. Please sign the Adobe CLA in the checks section so we can merge this.

@devops-devdocs
Copy link

@devops-devdocs imported this pull request

@pykettk
Copy link
Contributor Author

pykettk commented Sep 30, 2024

@jeff-matthews It looks like it's already signed? Or is it a different CLA to the one used for the magento/magento2 repo?

image

@jeff-matthews
Copy link
Contributor

Ah! Thanks @pykettk. I guess I was mistaken or there was a delay in the check showing success.

@adobe-bot adobe-bot merged commit 7f1a489 into AdobeDocs:main Sep 30, 2024
1 check passed
@pykettk pykettk deleted the patch-1 branch September 30, 2024 15:15
@pykettk
Copy link
Contributor Author

pykettk commented Sep 30, 2024

It's all good - thanks for such a prompt response, @jeff-matthews 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical Updates to the code or processes that alter the technical content of the doc
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants