Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A servlet to export redirects to a TXT file to use with pipeline-free redirects #3484

Merged
merged 9 commits into from
Dec 13, 2024
Merged

A servlet to export redirects to a TXT file to use with pipeline-free redirects #3484

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3be28e1
A servlet to export redirects to a TXT file to use with pipeline-free…
YegorKozlov Nov 30, 2024
d747a74
update changelog
YegorKozlov Nov 30, 2024
d7ff41d
#3484 add selector to filter redirects by status code
YegorKozlov Dec 1, 2024
858fda6
code climate issues
YegorKozlov Dec 1, 2024
dd8862c
fix failing text on win
YegorKozlov Dec 2, 2024
0b631d5
code climate issues
YegorKozlov Dec 2, 2024
ef591ba
touch the code to re-trigger build
YegorKozlov Dec 3, 2024
be4f170
Merge branch 'master' into develop
davidjgonzalez Dec 5, 2024
0f103df
Merge branch 'master' into develop
davidjgonzalez Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions bundle/src/main/java/com/adobe/acs/commons/redirects/servlets/RewriteMapServlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
/*
/*-
* #%L
* ACS AEM Commons Bundle
*
* %%
* Copyright (C) 2013 - 2024 Adobe
*
* %%
* Licensed under the Apache License, Version 2.0 (the "License");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YegorKozlov I'm not sure if that makes sense - or should rather https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/.codeclimate/header.txt be tuned instead? Also the other Java files do not seem to adhere to this pattern.

@kwin @joerghoh @davidjgonzalez WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krystiannowak this %% thing does not make much sense to me, but I believe we've always had it, since the header check was introduced in #1345 back in 2018

Also the other Java files do not seem to adhere to this pattern.

Yep. We have quite a bit of the header variations across the project.

* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
Expand All @@ -14,6 +15,7 @@
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
* #L%
*/
package com.adobe.acs.commons.redirects.servlets;

Expand Down Expand Up @@ -51,6 +53,7 @@ public class RewriteMapServlet extends SlingSafeMethodsServlet {
private static final long serialVersionUID = -3564475196678277711L;

@Override
@SuppressWarnings("java:S3457")
protected void doGet(SlingHttpServletRequest request, SlingHttpServletResponse response)
throws ServletException, IOException {
response.setContentType(ContentType.TEXT_PLAIN.getMimeType());
Expand Down
8 changes: 5 additions & 3 deletions bundle/src/test/java/com/adobe/acs/commons/redirects/servlets/RewriteMapServletTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
/*
/*-
* #%L
* ACS AEM Commons Bundle
*
* %%
* Copyright (C) 2013 - 2024 Adobe
*
* %%
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
Expand All @@ -14,6 +15,7 @@
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
* #L%
*/
package com.adobe.acs.commons.redirects.servlets;

Expand Down
Loading