-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy Sites Publish URL #3481
Merged
davidjgonzalez
merged 23 commits into
Adobe-Consulting-Services:master
from
krassib:feature/view-publish-url-sites
Dec 13, 2024
Merged
Copy Sites Publish URL #3481
davidjgonzalez
merged 23 commits into
Adobe-Consulting-Services:master
from
krassib:feature/view-publish-url-sites
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode climate errors.
krassib
force-pushed
the
feature/view-publish-url-sites
branch
from
November 27, 2024 20:20
2da1d13
to
1729e70
Compare
…or missing configs, comments.
…ation of valiable too far form usage.
davidjgonzalez
requested changes
Dec 3, 2024
bundle/src/main/java/com/adobe/acs/commons/wcm/impl/CopySitesPublishUrlFeature.java
Outdated
Show resolved
Hide resolved
bundle/src/main/java/com/adobe/acs/commons/wcm/impl/PublishUrlServlet.java
Outdated
Show resolved
Hide resolved
ui.apps/src/main/content/jcr_root/apps/acs-commons/authoring/sites-copy-publishurl/.content.xml
Outdated
Show resolved
Hide resolved
...content/jcr_root/apps/acs-commons/authoring/sites-copy-publishurl/sites-copy-publish-url.css
Outdated
Show resolved
Hide resolved
ui.apps/src/main/content/jcr_root/apps/wcm/core/content/editor/.content.xml
Outdated
Show resolved
Hide resolved
...rc/main/content/jcr_root/apps/wcm/core/content/editor/_jcr_content/content/items/content.xml
Outdated
Show resolved
Hide resolved
bundle/src/main/java/com/adobe/acs/commons/wcm/impl/PublishUrlServlet.java
Outdated
Show resolved
Hide resolved
…ure service component
krassib
force-pushed
the
feature/view-publish-url-sites
branch
from
December 9, 2024 23:26
d9e876b
to
f05279c
Compare
…' into feature/view-publish-url-sites
… it won;t be active until config is defined
bundle/src/main/java/com/adobe/acs/commons/wcm/impl/PublishUrlServlet.java
Show resolved
Hide resolved
bundle/src/test/java/com/adobe/acs/commons/wcm/impl/CopySitesPublishUrlFeatureTest.java
Show resolved
Hide resolved
bundle/src/test/java/com/adobe/acs/commons/wcm/impl/PublishUrlServletTest.java
Outdated
Show resolved
Hide resolved
..._content/content/items/content/header/items/acs-commons_copy-publish-url-dialog/.content.xml
Outdated
Show resolved
Hide resolved
.../config.author/org.apache.sling.jcr.repoinit.RepositoryInitializer-acs-commons-author.config
Show resolved
Hide resolved
…n opening the popup dialog. The only condition checked is the feature 'copysitespublishurlfeature' based.
davidjgonzalez
approved these changes
Dec 13, 2024
davidjgonzalez
merged commit Dec 13, 2024
15f3dd9
into
Adobe-Consulting-Services:master
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the issue #3480